[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [pbmserv-dev] gamerz.php



On Tue, 26 Jul 2005, Paul van Wamelen wrote:
> On Tue, 26 Jul 2005, John Williams wrote:
> > I have XiangQi clicking and moving now.  Still need to figure out how to
> > rotate the board.
>
> Can it be test driven? If so, where?

My usual test server does not have a direct internet connection.  I might
be able to set something up on a different machine, but I probably don't
have time this week, and next week I'll be out of town.

> > > No, but if stuff is going to start coming in from different contributors
> > > then we have to be carefull of not overwriting each other. If you make no
> > > changes to the base files it shouldn't be a problem though...
> >
> > I won't change the base files without checking with you.
> >
> > But here's a suggestion:
> >
> > The $xG and $yG parameters to ReadAndShowCSSBoard are not being used.
> > This patch uses them for the size of the pieces, so I can specify the size
> > of the pieces as well as the board background ($xG and $yG for
> > BeginCSSBoard).  Will this break any existing games?  One would have to
> > pass the real size or 'auto' to get the existing behavior.
>
> Good, that is what they were intended for. I believe I removed printing
> the sizes of the pieces because I couldn't find a reason they were needed.
> Do you know of such a reason? pngfix.js claims they are needed, but
> testing seems to indicate otherwise. I'd rather keep the HTML as small as
> possible.

I used them to be able to display the board in different sizes using the
same graphics.

I could make it omit the height and width if $xG and $yG are 0 or ''.

~ John Williams